Add support EGLImage-based texture #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for sending the PR. Can you please update AUTHORS too and sign a DCO (Developer Certificate of Origin) in git comment? Also, it's unclear whether we can contribute this software to flutter/engine, but do you agree to delegate all rights related to this PR to Sony? |
|
It looks good to me, but please fix code format check error. |
Signed-off-by: Makoto Sato <[email protected]>
makotosato-at
force-pushed
the
eglimage_support
branch
from
d338eba
to
4172c32
Compare
|
Thank you for your review.
I agree to delegate all rights related to this PR to Sony. |
HidenoriMatsubayashi
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I needed to add EGLImage-based texture support to flutter-embedded-linux to improve video_player playback performance.
So I added support.
Relevant issue: sony/flutter-elinux-plugins#64